third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h ('k') | third_party/WebKit/Source/modules/fetch/FetchHeaderList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

index 3345d35d964984351efbede3f52e2364f252a380..0083b340361a8b6edb48671905ce3564b06908ba 100644

--- a/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp

@@ -195,11 +195,11 @@ class ResponsesAccumulator : public RefCounted<ResponsesAccumulator> {

return WTF::codePointCompareLessThan(a.request, b.request);

});

if (m_params.skipCount > 0)

- m_responses.remove(0, m_params.skipCount);

+ m_responses.erase(0, m_params.skipCount);

bool hasMore = false;

if (static_cast<size_t>(m_params.pageSize) < m_responses.size()) {

- m_responses.remove(m_params.pageSize,

- m_responses.size() - m_params.pageSize);

+ m_responses.erase(m_params.pageSize,

+ m_responses.size() - m_params.pageSize);

hasMore = true;

}

std::unique_ptr<Array<DataEntry>> array = Array<DataEntry>::create();