third_party/WebKit/Source/core/css/StylePropertySet.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/StylePropertySet.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/StylePropertySet.cpp

diff --git a/third_party/WebKit/Source/core/css/StylePropertySet.cpp b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

index 78a70e9dce6944681cfc7bfef88bb71297de0f92..0c5662fde1d1914f9de1eeeea22a8ff9989e03ad 100644

--- a/third_party/WebKit/Source/core/css/StylePropertySet.cpp

+++ b/third_party/WebKit/Source/core/css/StylePropertySet.cpp

@@ -230,7 +230,7 @@ bool MutableStylePropertySet::removePropertyAtIndex(int propertyIndex,

// A more efficient removal strategy would involve marking entries as empty

// and sweeping them when the vector grows too big.

- m_propertyVector.remove(propertyIndex);

+ m_propertyVector.erase(propertyIndex);

return true;

}