third_party/WebKit/Source/core/css/CSSValueList.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSValueList.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSValueList.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSValueList.cpp b/third_party/WebKit/Source/core/css/CSSValueList.cpp

index fac73e792404af9d4564c4b06ad368a013f65138..99b0ce793b228909a910a920e96b5efa087a188f 100644

--- a/third_party/WebKit/Source/core/css/CSSValueList.cpp

+++ b/third_party/WebKit/Source/core/css/CSSValueList.cpp

@@ -48,7 +48,7 @@ bool CSSValueList::removeAll(const CSSValue& val) {

for (int index = m_values.size() - 1; index >= 0; --index) {

Member<const CSSValue>& value = m_values.at(index);

if (value && *value == val) {

- m_values.remove(index);

+ m_values.erase(index);

found = true;

}