Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1346)

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Created:
3 years, 9 months ago by mrunal
Modified:
3 years, 8 months ago
Reviewers:
tkent, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, jfernandez, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary This one is for the existing DCHECKS which were already present. BUG=697685 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2770203002 Cr-Commit-Position: refs/heads/master@{#462623} Committed: https://chromium.googlesource.com/chromium/src/+/2fe329196d1596b0e516fda0727e8ebce5996152

Patch Set 1 #

Patch Set 2 : Add few more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -46 lines) Patch
M third_party/WebKit/Source/core/layout/FragmentainerIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/Grid.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 1 5 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchor.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc View 1 2 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_inline_items_builder.cc View 1 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (11 generated)
eae
LGTM
3 years, 8 months ago (2017-04-06 06:55:07 UTC) #9
tkent
lgtm
3 years, 8 months ago (2017-04-06 07:01:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2770203002/20001
3 years, 8 months ago (2017-04-06 21:00:06 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:19:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fe329196d1596b0e516fda0727e...

Powered by Google App Engine
This is Rietveld 408576698