third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

index b2885eadf0fca1986d525169bbdcfa3debcf9a4d..cb8734ddaef90960a9536d38fb25dde3a9468805 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

@@ -89,7 +89,8 @@ NGFragmentBuilder& NGFragmentBuilder::AddChild(

case NGPhysicalBoxFragment::kFragmentLineBox:

// NGInlineNode produces multiple line boxes in an anonymous box. Only

// the last break token is needed to be reported to the parent.

- DCHECK(child->BreakToken() && child->BreakToken()->InputNode() == node_);

+ DCHECK(child->BreakToken());

+ DCHECK_EQ(child->BreakToken()->InputNode(), node_);

last_inline_break_token_ =

child->BreakToken()->IsFinished() ? nullptr : child->BreakToken();

break;