third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

diff --git a/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h b/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

index b55f2e672c0ece78d0019d753b49c45ca261b92e..e21ef89b6a7ca7c8986ffc1625289ccc23f592b6 100644

--- a/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

+++ b/third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h

@@ -45,7 +45,7 @@ class ShapeInterval {

DCHECK(isUndefined());

}

- ShapeInterval(T x1, T x2) : m_x1(x1), m_x2(x2) { DCHECK(x2 >= x1); }

+ ShapeInterval(T x1, T x2) : m_x1(x1), m_x2(x2) { DCHECK_GE(x2, x1); }

bool isUndefined() const { return m_x2 < m_x1; }

T x1() const { return isUndefined() ? 0 : m_x1; }