Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)
Patch Set: Add few more Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
index 5347de1862c83c3c579f7791342a7f4cdfdb3de4..245e470358b897c5c92815ef7a373621dd8c6108 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc
@@ -88,7 +88,7 @@ void ComputeAbsoluteHorizontal(const NGConstraintSpace& space,
Optional<LayoutUnit> width = incoming_width;
NGPhysicalSize container_size =
space.AvailableSize().ConvertToPhysical(space.WritingMode());
- DCHECK(container_size.width != NGSizeIndefinite);
+ DCHECK_NE(container_size.width, NGSizeIndefinite);
// Solving the equation:
// left + marginLeft + width + marginRight + right = container width
@@ -250,7 +250,7 @@ void ComputeAbsoluteVertical(const NGConstraintSpace& space,
NGPhysicalSize container_size =
space.AvailableSize().ConvertToPhysical(space.WritingMode());
- DCHECK(container_size.height != NGSizeIndefinite);
+ DCHECK_NE(container_size.height, NGSizeIndefinite);
// Solving the equation:
// top + marginTop + height + marginBottom + bottom

Powered by Google App Engine
This is Rietveld 408576698