third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

index 1a562c69b6bad74b1966fbbfa9a0009000e817d2..c29085580b8c8d2c849a84f55423dc1e51ed55cd 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp

@@ -314,7 +314,7 @@ const LayoutSVGInlineText* SVGTextLayoutEngine::currentLogicalCharacterMetrics(

m_descendantTextNodes[m_currentLogicalTextNodeIndex];

const Vector<SVGTextMetrics>* metricsList = &logicalTextNode->metricsList();

unsigned metricsListSize = metricsList->size();

- DCHECK(m_logicalMetricsListOffset <= metricsListSize);

+ DCHECK_LE(m_logicalMetricsListOffset, metricsListSize);

// Find the next non-collapsed text metrics cell.

while (true) {

« no previous file with comments | « third_party/WebKit/Source/core/layout/shapes/ShapeInterval.h ('k') | no next file » | no next file with comments »