third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ScrollAnchor.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

index c146c8bbb7cbf6abdb39ed4929975891d8bbe732..4fbe496127e1615550203ea106feb6c4840d7bc1 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

@@ -192,7 +192,7 @@ CompositingLayerAssigner::getReasonsPreventingSquashing(

if (layer->nearestFixedPositionLayer() !=

squashingLayer.nearestFixedPositionLayer())

return SquashingDisallowedReasonNearestFixedPositionMismatch;

- DCHECK(layer->layoutObject().style()->position() != EPosition::kFixed);

+ DCHECK_NE(layer->layoutObject().style()->position(), EPosition::kFixed);

if ((squashingLayer.layoutObject().style()->subtreeWillChangeContents() &&

squashingLayer.layoutObject()