Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)
Patch Set: Add few more Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
index a108dbfab7c70003983ec3048c1c2c8eef9c4def..cf1fd5db1db319a5057c4fbde5743a4c0d9e25f4 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_layout_algorithm.cc
@@ -210,7 +210,7 @@ const NGLayoutResult* NGInlineLayoutAlgorithm::LayoutItem(
if (*layout_result)
return layout_result->get();
- DCHECK(item.Type() == NGLayoutInlineItem::kAtomicInline);
+ DCHECK_EQ(item.Type(), NGLayoutInlineItem::kAtomicInline);
NGBlockNode* node = new NGBlockNode(item.GetLayoutObject());
// TODO(kojii): Keep node in NGLayoutInlineItem.
const ComputedStyle& style = node->Style();
@@ -540,8 +540,8 @@ RefPtr<NGLayoutResult> NGInlineLayoutAlgorithm::Layout() {
}
MinMaxContentSize NGInlineLayoutAlgorithm::ComputeMinMaxContentSizeByLayout() {
- DCHECK(ConstraintSpace().AvailableSize().inline_size == LayoutUnit() &&
- ConstraintSpace().AvailableSize().block_size == NGSizeIndefinite);
+ DCHECK_EQ(ConstraintSpace().AvailableSize().inline_size, LayoutUnit());
+ DCHECK_EQ(ConstraintSpace().AvailableSize().block_size, NGSizeIndefinite);
if (!Node()->Text().isEmpty())
NGLineBreaker().BreakLines(this, Node()->Text(), start_offset_);
MinMaxContentSize sizes;

Powered by Google App Engine
This is Rietveld 408576698