third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp ('k') | third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index 7893a3b065aee291e182fa5392fabb9bd62eb5ab..d704b8150bb05d7e6d7c782922793a0c10c56b41 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -1119,9 +1119,10 @@ inline bool BreakingContext::handleText(WordMeasurements& wordMeasurements,

if (hyphenation && (m_nextObject || isLineEmpty ||

hasVisibleText(layoutText, m_current.offset()))) {

m_width.addUncommittedWidth(-wordMeasurement.width);

- DCHECK(lastSpace == static_cast<unsigned>(wordMeasurement.startOffset));

- DCHECK(m_current.offset() ==

- static_cast<unsigned>(wordMeasurement.endOffset));

+ DCHECK_EQ(lastSpace,

+ static_cast<unsigned>(wordMeasurement.startOffset));

+ DCHECK_EQ(m_current.offset(),

+ static_cast<unsigned>(wordMeasurement.endOffset));

if (hyphenate(layoutText, style, font, *hyphenation,

lastSpaceWordSpacing, wordMeasurement)) {

m_width.addUncommittedWidth(wordMeasurement.width);