Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)
Patch Set: Add few more Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
index f18089c598d326dec3cf680e72c2319d6e743e83..18b05ce0aab5c945dd9c81fe42b541386c57dc52 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc
@@ -121,7 +121,7 @@ LayoutUnit ResolveBlockLength(const NGConstraintSpace& constraint_space,
LayoutUnit content_size,
LengthResolveType type) {
DCHECK(!length.isMaxSizeNone());
- DCHECK(type != LengthResolveType::kMarginBorderPaddingSize);
+ DCHECK_NE(type, LengthResolveType::kMarginBorderPaddingSize);
if (type == LengthResolveType::kMinSize && length.isAuto())
return LayoutUnit();
@@ -290,7 +290,7 @@ int ResolveUsedColumnCount(int computed_count,
DCHECK(computed_count);
return computed_count;
}
- DCHECK(computed_size > LayoutUnit());
+ DCHECK_GT(computed_size, LayoutUnit());
int count_from_width =
((available_size + used_gap) / (computed_size + used_gap)).toInt();
count_from_width = std::max(1, count_from_width);

Powered by Google App Engine
This is Rietveld 408576698