third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp - Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Issue 2770203002: Replace DCHECK with DCHECK_op and split some DCHECKs wherever necessary (Closed)

Patch Set: Add few more Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

index 909f9c5e1e211d35e36dfba5bf9f1b0360c50610..b0330249f74b61a4318dedf014357d7ab2ac75fa 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

@@ -1663,7 +1663,8 @@ ItemPosition LayoutFlexibleBox::alignmentForChild(

.resolvedAlignSelf(selfAlignmentNormalBehavior(),

child.isAnonymous() ? style() : nullptr)

.position();

- DCHECK(align != ItemPositionAuto && align != ItemPositionNormal);

+ DCHECK_NE(align, ItemPositionAuto);

+ DCHECK_NE(align, ItemPositionNormal);

if (align == ItemPositionBaseline && hasOrthogonalFlow(child))

align = ItemPositionFlexStart;