Remove unused feedback class in dom distiller component

Remove unused feedback class in dom distiller component

The external feedback reporter for dom distiller is no longer used
since the feature has launched. The file is not included in any gn
build files and is one of many tracked here:

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0ywe7bZs

This change also removes the unused feedback form that was part of
the dom distiller UI and all of its internals.

BUG=

Review-Url: https://codereview.chromium.org/2768093004
Cr-Commit-Position: refs/heads/master@{#459522}
Committed: https://chromium.googlesource.com/chromium/src/+/01d9701758b64c7af4eb930f540aa949f3da95ff

[mdjones, 2017-03-23 16:08:19]

mdjones@chromium.org changed reviewers:
+ wychen@chromium.org

[mdjones, 2017-03-23 16:08:20]

ptal

[mdjones, 2017-03-23 16:11:27]

It looks like we have another dead file in blink:

third_party/WebKit/public/platform/WebDistillability.h

[wychen, 2017-03-23 18:18:57]

On 2017/03/23 16:11:27, mdjones wrote:
> It looks like we have another dead file in blink:
> 
> third_party/WebKit/public/platform/WebDistillability.h

I think WebDistillability is used.

[wychen, 2017-03-23 20:43:55]

lgtm.

Do we want to clean other related files as well? Like removing
ExternalFeedbackReporter.java and cleaning up distiller_ui_handle.h and
distiller_ui_handle_android.h.

[mdjones, 2017-03-24 16:48:09]

Description was changed from

==========
Remove unused feedback class in dom distiller component

The external feedback reporter for dom distiller is no longer used
since the feature has launched. The file is not included in any gn
build files and is one of many tracked here:

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...

BUG=
==========

to

==========
Remove unused feedback class in dom distiller component

The external feedback reporter for dom distiller is no longer used
since the feature has launched. The file is not included in any gn
build files and is one of many tracked here:

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...

This change also removes the unused feedback form that was part of
the dom distiller UI and all of its internals.

BUG=
==========

[mdjones, 2017-03-24 16:48:28]

On 2017/03/23 20:43:55, wychen wrote:
> lgtm.
> 
> Do we want to clean other related files as well? Like removing
> ExternalFeedbackReporter.java and cleaning up distiller_ui_handle.h and
> distiller_ui_handle_android.h.

Yes, done.

[mdjones, 2017-03-24 16:49:44]

mdjones@chromium.org changed reviewers:
+ nyquist@chromium.org

[mdjones, 2017-03-24 16:49:44]

+nyquist for chrome/

[nyquist, 2017-03-24 17:06:40]

nice! lgtm

[mdjones, 2017-03-24 17:09:08]

mdjones@chromium.org changed reviewers:
+ tsepez@chromium.org

[mdjones, 2017-03-24 17:09:08]

+tsepez for *.mojom

[Tom Sepez, 2017-03-24 17:10:41]

RS LGTM on deleting code.

[wychen, 2017-03-24 17:57:21]

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
File components/dom_distiller/core/css/distilledpage.css (right):

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
components/dom_distiller/core/css/distilledpage.css:389: @keyframes
fadeOutAndSwipeAnimation {
This can also be removed, right?

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
File components/dom_distiller/core/javascript/dom_distiller_viewer.js (right):

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
components/dom_distiller/core/javascript/dom_distiller_viewer.js:122:
document.getElementById('contentWrap').addEventListener('transitionend',
Doesn't seem needed anymore.

[mdjones, 2017-03-24 18:08:29]

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
File components/dom_distiller/core/css/distilledpage.css (right):

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
components/dom_distiller/core/css/distilledpage.css:389: @keyframes
fadeOutAndSwipeAnimation {
On 2017/03/24 17:57:20, wychen wrote:
> This can also be removed, right?

Done.

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
File components/dom_distiller/core/javascript/dom_distiller_viewer.js (right):

https://codereview.chromium.org/2768093004/diff/20001/components/dom_distille...
components/dom_distiller/core/javascript/dom_distiller_viewer.js:122:
document.getElementById('contentWrap').addEventListener('transitionend',
On 2017/03/24 17:57:20, wychen wrote:
> Doesn't seem needed anymore.

Done.

[wychen, 2017-03-24 18:11:07]

lgtm

[mdjones, 2017-03-24 18:12:34]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2017-03-24 18:12:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/2768093004/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-03-24 18:13:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 19:37:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490379154905140,
"parent_rev": "ce15846003ee139aa4627fb6357da7c80affa4a2", "commit_rev":
"01d9701758b64c7af4eb930f540aa949f3da95ff"}

[commit-bot: I haz the power, 2017-03-24 19:37:51]

Description was changed from

==========
Remove unused feedback class in dom distiller component

The external feedback reporter for dom distiller is no longer used
since the feature has launched. The file is not included in any gn
build files and is one of many tracked here:

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...

This change also removes the unused feedback form that was part of
the dom distiller UI and all of its internals.

BUG=
==========

to

==========
Remove unused feedback class in dom distiller component

The external feedback reporter for dom distiller is no longer used
since the feature has launched. The file is not included in any gn
build files and is one of many tracked here:

https://docs.google.com/spreadsheets/d/15az3FMl-jAS0mx4E9XVSBVHVpmEzo-9EAGY0y...

This change also removes the unused feedback form that was part of
the dom distiller UI and all of its internals.

BUG=

Review-Url: https://codereview.chromium.org/2768093004
Cr-Commit-Position: refs/heads/master@{#459522}
Committed:
https://chromium.googlesource.com/chromium/src/+/01d9701758b64c7af4eb930f540a...
==========

[commit-bot: I haz the power, 2017-03-24 19:37:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/01d9701758b64c7af4eb930f540a...