Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: components/dom_distiller/core/viewer.h

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_ 5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_
6 #define COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_ 6 #define COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 10
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "components/dom_distiller/core/distilled_page_prefs.h" 13 #include "components/dom_distiller/core/distilled_page_prefs.h"
14 #include "ui/gfx/geometry/size.h" 14 #include "ui/gfx/geometry/size.h"
15 15
16 namespace dom_distiller { 16 namespace dom_distiller {
17 17
18 class DistilledArticleProto; 18 class DistilledArticleProto;
19 class DistilledPageProto; 19 class DistilledPageProto;
20 class DomDistillerServiceInterface; 20 class DomDistillerServiceInterface;
21 class ViewerHandle; 21 class ViewerHandle;
22 class ViewRequestDelegate; 22 class ViewRequestDelegate;
23 23
24 namespace viewer { 24 namespace viewer {
25 25
26 // Returns the JavaScript to show the feedback footer for a distilled page.
27 const std::string GetShowFeedbackFormJs();
28
29 // Returns an HTML template page based on the given |page_proto| which provides 26 // Returns an HTML template page based on the given |page_proto| which provides
30 // basic information about the page (i.e. title, text direction, etc.). This is 27 // basic information about the page (i.e. title, text direction, etc.). This is
31 // supposed to be displayed to the end user. The returned HTML should be 28 // supposed to be displayed to the end user. The returned HTML should be
32 // considered unsafe, so callers must ensure rendering it does not compromise 29 // considered unsafe, so callers must ensure rendering it does not compromise
33 // Chrome. 30 // Chrome.
34 const std::string GetUnsafeArticleTemplateHtml( 31 const std::string GetUnsafeArticleTemplateHtml(
35 const std::string original_url, 32 const std::string original_url,
36 const DistilledPagePrefs::Theme theme, 33 const DistilledPagePrefs::Theme theme,
37 const DistilledPagePrefs::FontFamily font_family); 34 const DistilledPagePrefs::FontFamily font_family);
38 35
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 const std::string GetDistilledPageThemeJs(DistilledPagePrefs::Theme theme); 90 const std::string GetDistilledPageThemeJs(DistilledPagePrefs::Theme theme);
94 91
95 // Returns JavaScript corresponding to setting the font scaling. 92 // Returns JavaScript corresponding to setting the font scaling.
96 const std::string GetDistilledPageFontScalingJs(float scaling); 93 const std::string GetDistilledPageFontScalingJs(float scaling);
97 94
98 } // namespace viewer 95 } // namespace viewer
99 96
100 } // namespace dom_distiller 97 } // namespace dom_distiller
101 98
102 #endif // COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_ 99 #endif // COMPONENTS_DOM_DISTILLER_CORE_VIEWER_H_
OLDNEW
« no previous file with comments | « components/dom_distiller/core/javascript/dom_distiller_viewer.js ('k') | components/dom_distiller/core/viewer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698