Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: components/dom_distiller/core/experiments.cc

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/core/experiments.cc
diff --git a/components/dom_distiller/core/experiments.cc b/components/dom_distiller/core/experiments.cc
index cc882d1f0fb469d47a161261cf08eac66154932a..900daecd4b50191ebee2d68ceba68582b543f0e0 100644
--- a/components/dom_distiller/core/experiments.cc
+++ b/components/dom_distiller/core/experiments.cc
@@ -47,29 +47,4 @@ DistillerHeuristicsType GetDistillerHeuristicsType() {
}
return DistillerHeuristicsType::ADABOOST_MODEL;
}
-
-bool ShouldShowFeedbackForm() {
- const std::string group_name =
- base::FieldTrialList::FindFullName("ReaderModeUIFeedback");
- const std::string switch_value =
- base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
- switches::kReaderModeFeedback);
- if (switch_value != "") {
- if (switch_value == switches::reader_mode_feedback::kOn) {
- return true;
- }
- if (switch_value == switches::reader_mode_feedback::kOff) {
- return false;
- }
- NOTREACHED() << "Invalid value for " << switches::kReaderModeFeedback;
- } else {
- if (group_name == "DoNotShow") {
- return false;
- }
- if (group_name == "Show") {
- return true;
- }
- }
- return false;
-}
}
« no previous file with comments | « components/dom_distiller/core/experiments.h ('k') | components/dom_distiller/core/javascript/dom_distiller_viewer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698