Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4254)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
index fcf48f1785f113a5d5f2bc3d1f57985e663a37fd..1aa2994766cd3097c08683dab39d6b12ee62c1fd 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java
@@ -7,16 +7,11 @@ package org.chromium.chrome.browser.dom_distiller;
import android.app.Activity;
import android.support.v7.app.AlertDialog;
-import org.chromium.base.ThreadUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.AppHooks;
import org.chromium.chrome.browser.compositor.bottombar.OverlayPanel.StateChangeReason;
-import org.chromium.chrome.browser.feedback.FeedbackCollector;
-import org.chromium.chrome.browser.feedback.FeedbackReporter;
-import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.content_public.browser.WebContents;
import org.chromium.ui.base.WindowAndroid;
@@ -25,13 +20,6 @@ import org.chromium.ui.base.WindowAndroid;
*/
@JNINamespace("dom_distiller::android")
public final class DomDistillerUIUtils {
- private static final String DISTILLATION_QUALITY_KEY = "Distillation quality";
- private static final String DISTILLATION_QUALITY_GOOD = "good";
- private static final String DISTILLATION_QUALITY_BAD = "bad";
-
- // Static handle to object for feedback reporting.
- private static FeedbackReporter sFeedbackReporter;
-
// Static handle to Reader Mode's manager.
private static ReaderModeManagerDelegate sManagerDelegate;
@@ -44,36 +32,6 @@ public final class DomDistillerUIUtils {
}
/**
- * A static method for native code to open the external feedback form UI.
- * @param webContents The WebContents containing the distilled content.
- * @param url The URL to report feedback for.
- * @param good True if the feedback is good and false if not.
- */
- @CalledByNative
- public static void reportFeedbackWithWebContents(
- WebContents webContents, String url, final boolean good) {
- ThreadUtils.assertOnUiThread();
- // TODO(mdjones): It would be better to get the WebContents from the manager so that the
- // native code does not need to depend on RenderFrame.
- Activity activity = getActivityFromWebContents(webContents);
- if (activity == null) return;
-
- if (sFeedbackReporter == null) {
- sFeedbackReporter = AppHooks.get().createFeedbackReporter();
- }
- FeedbackCollector.create(activity, Profile.getLastUsedProfile(), url,
- new FeedbackCollector.FeedbackResult() {
- @Override
- public void onResult(FeedbackCollector collector) {
- String quality =
- good ? DISTILLATION_QUALITY_GOOD : DISTILLATION_QUALITY_BAD;
- collector.add(DISTILLATION_QUALITY_KEY, quality);
- sFeedbackReporter.reportFeedback(collector);
- }
- });
- }
-
- /**
* A static method for native code to call to open the distiller UI settings.
* @param webContents The WebContents containing the distilled content.
*/

Powered by Google App Engine
This is Rietveld 408576698