Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/viewer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/viewer.cc
diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc
index efc5c6ab46bcb54ebf1e2085c063982ac397aa40..66ce14298420928e1f3942f38100e9bb5d704d6c 100644
--- a/components/dom_distiller/core/viewer.cc
+++ b/components/dom_distiller/core/viewer.cc
@@ -149,25 +149,6 @@ std::string ReplaceHtmlTemplateValues(
namespace viewer {
-const std::string GetShowFeedbackFormJs() {
- base::Value question_val(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_QUALITY_QUESTION));
- base::Value no_val(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_QUALITY_ANSWER_NO));
- base::Value yes_val(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_QUALITY_ANSWER_YES));
-
- std::string question;
- std::string yes;
- std::string no;
-
- base::JSONWriter::Write(question_val, &question);
- base::JSONWriter::Write(yes_val, &yes);
- base::JSONWriter::Write(no_val, &no);
-
- return "showFeedbackForm(" + question + ", " + yes + ", " + no + ");";
-}
-
const std::string GetUnsafeIncrementalDistilledPageJs(
const DistilledPageProto* page_proto,
const bool is_last_page) {
@@ -194,9 +175,6 @@ const std::string GetErrorPageJs() {
page_update += "addToPage(" + output + ");";
page_update += GetSetTextDirectionJs(std::string("auto"));
page_update += GetToggleLoadingIndicatorJs(true);
- if (ShouldShowFeedbackForm()) {
- page_update += GetShowFeedbackFormJs();
- }
return page_update;
}
« no previous file with comments | « components/dom_distiller/core/viewer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698