components/dom_distiller/content/browser/distiller_javascript_service_impl.h - Issue 2768093004: Remove unused feedback class in dom distiller component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/browser/distiller_javascript_service_impl.h

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/dom_distiller/distiller_ui_handle_android.cc ('k') | components/dom_distiller/content/browser/distiller_javascript_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/browser/distiller_javascript_service_impl.h

diff --git a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h

index e8ac057ee0bb1ac914c1063e1146ccb1170f6b1f..829df278081092da51b3459cff05312bf0e61a8e 100644

--- a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h

+++ b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h

@@ -22,9 +22,6 @@ class DistillerJavaScriptServiceImpl

// Mojo mojom::DistillerJavaScriptService implementation.

- // Send UMA feedback and start the external feedback reporter if one exists.

- void HandleDistillerFeedbackCall(bool good) override;

// Make a call into Android to close the overlay panel containing reader mode.

void HandleDistillerClosePanelCall(bool animate) override;