Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: components/dom_distiller/core/javascript/dom_distiller_viewer.js

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/experiments.cc ('k') | components/dom_distiller/core/viewer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/javascript/dom_distiller_viewer.js
diff --git a/components/dom_distiller/core/javascript/dom_distiller_viewer.js b/components/dom_distiller/core/javascript/dom_distiller_viewer.js
index e325f3c02166e03c1bc21f2625fd51582a8769bd..e75875d98c24454c7b9cfdb3c175f18b9e3f2f89 100644
--- a/components/dom_distiller/core/javascript/dom_distiller_viewer.js
+++ b/components/dom_distiller/core/javascript/dom_distiller_viewer.js
@@ -111,24 +111,6 @@ function useFontScaling(scaling) {
pincher.useFontScaling(scaling);
}
-/**
- * Show the distiller feedback form.
- * @param questionText The i18n text for the feedback question.
- * @param yesText The i18n text for the feedback answer 'YES'.
- * @param noText The i18n text for the feedback answer 'NO'.
- */
-function showFeedbackForm(questionText, yesText, noText) {
- // If the distiller is running on iOS, do not show the feedback form. This
- // variable is set in distiller_viewer.cc before this function is run.
- if (distiller_on_ios) return;
-
- document.getElementById('feedbackYes').innerText = yesText;
- document.getElementById('feedbackNo').innerText = noText;
- document.getElementById('feedbackQuestion').innerText = questionText;
-
- document.getElementById('feedbackContainer').classList.remove("hidden");
-}
-
// Add a listener to the "View Original" link to report opt-outs.
document.getElementById('closeReaderView').addEventListener('click',
function(e) {
@@ -137,41 +119,6 @@ document.getElementById('closeReaderView').addEventListener('click',
}
}, true);
-document.getElementById('feedbackYes').addEventListener('click', function(e) {
- if (distiller) {
- distiller.sendFeedback(true);
- }
- document.getElementById('feedbackContainer').className += " fadeOut";
-}, true);
-
-document.getElementById('feedbackNo').addEventListener('click', function(e) {
- if (distiller) {
- distiller.sendFeedback(false);
- }
- document.getElementById('feedbackContainer').className += " fadeOut";
-}, true);
-
-document.getElementById('feedbackContainer').addEventListener('animationend',
- function(e) {
- var feedbackContainer = document.getElementById('feedbackContainer');
- feedbackContainer.classList.remove("fadeOut");
- document.getElementById('contentWrap').style.paddingBottom =
- window.getComputedStyle(feedbackContainer).height;
- feedbackContainer.className += " hidden";
- setTimeout(function() {
- // Close the gap where the feedback form was.
- var contentWrap = document.getElementById('contentWrap');
- contentWrap.style.transition = '0.5s';
- contentWrap.style.paddingBottom = '';
- }, 0);
- }, true);
-
-document.getElementById('contentWrap').addEventListener('transitionend',
- function(e) {
- var contentWrap = document.getElementById('contentWrap');
- contentWrap.style.transition = '';
- }, true);
-
updateToolbarColor();
var pincher = (function() {
« no previous file with comments | « components/dom_distiller/core/experiments.cc ('k') | components/dom_distiller/core/viewer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698