Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: chrome/browser/android/dom_distiller/distiller_ui_handle_android.cc

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/dom_distiller/distiller_ui_handle_android.h" 5 #include "chrome/browser/android/dom_distiller/distiller_ui_handle_android.h"
6 6
7 #include "base/android/jni_string.h" 7 #include "base/android/jni_string.h"
8 #include "chrome/browser/ui/android/view_android_helper.h" 8 #include "chrome/browser/ui/android/view_android_helper.h"
9 #include "components/dom_distiller/core/url_utils.h" 9 #include "components/dom_distiller/core/url_utils.h"
10 #include "content/public/browser/web_contents.h" 10 #include "content/public/browser/web_contents.h"
11 #include "jni/DomDistillerUIUtils_jni.h" 11 #include "jni/DomDistillerUIUtils_jni.h"
12 #include "ui/android/window_android.h" 12 #include "ui/android/window_android.h"
13 #include "url/gurl.h" 13 #include "url/gurl.h"
14 14
15 using base::android::ScopedJavaLocalRef; 15 using base::android::ScopedJavaLocalRef;
16 16
17 namespace dom_distiller { 17 namespace dom_distiller {
18 18
19 namespace android { 19 namespace android {
20 20
21 // static 21 // static
22 void DistillerUIHandleAndroid::ReportExternalFeedback(
23 content::WebContents* web_contents,
24 const GURL& url,
25 const bool good) {
26 if (!web_contents)
27 return;
28
29 JNIEnv* env = base::android::AttachCurrentThread();
30 ScopedJavaLocalRef<jstring> jurl = base::android::ConvertUTF8ToJavaString(
31 env, url_utils::GetOriginalUrlFromDistillerUrl(url).spec());
32
33 Java_DomDistillerUIUtils_reportFeedbackWithWebContents(
34 env, web_contents->GetJavaWebContents(), jurl, good);
35 }
36
37 // static
38 void DistillerUIHandleAndroid::OpenSettings( 22 void DistillerUIHandleAndroid::OpenSettings(
39 content::WebContents* web_contents) { 23 content::WebContents* web_contents) {
40 JNIEnv* env = base::android::AttachCurrentThread(); 24 JNIEnv* env = base::android::AttachCurrentThread();
41 Java_DomDistillerUIUtils_openSettings(env, 25 Java_DomDistillerUIUtils_openSettings(env,
42 web_contents->GetJavaWebContents()); 26 web_contents->GetJavaWebContents());
43 } 27 }
44 28
45 // static 29 // static
46 void DistillerUIHandleAndroid::ClosePanel(bool animate) { 30 void DistillerUIHandleAndroid::ClosePanel(bool animate) {
47 JNIEnv* env = base::android::AttachCurrentThread(); 31 JNIEnv* env = base::android::AttachCurrentThread();
48 Java_DomDistillerUIUtils_closePanel(env, animate); 32 Java_DomDistillerUIUtils_closePanel(env, animate);
49 } 33 }
50 34
51 } // namespace android 35 } // namespace android
52 36
53 } // namespace dom_distiller 37 } // namespace dom_distiller
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698