components/dom_distiller/content/renderer/distiller_native_javascript.cc - Issue 2768093004: Remove unused feedback class in dom distiller component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distiller_native_javascript.cc

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)

Patch Set: address comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/common/distiller_javascript_service.mojom ('k') | components/dom_distiller/core/css/distilledpage.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distiller_native_javascript.cc

diff --git a/components/dom_distiller/content/renderer/distiller_native_javascript.cc b/components/dom_distiller/content/renderer/distiller_native_javascript.cc

index 7e5f90620ca0662f64793f48bb600ea62d2b7b80..a8af2dccc20e0b156c312ddb0896afab12d87153 100644

--- a/components/dom_distiller/content/renderer/distiller_native_javascript.cc

+++ b/components/dom_distiller/content/renderer/distiller_native_javascript.cc

@@ -45,12 +45,6 @@ void DistillerNativeJavaScript::AddJavaScriptObjectToFrame(

// wrapper function for binding. Note that calling distiller_js_service.get()

// does not transfer ownership of the interface.

BindFunctionToObject(

- distiller_obj, "sendFeedback",

- base::Bind(

- &mojom::DistillerJavaScriptService::HandleDistillerFeedbackCall,

- base::Unretained(distiller_js_service_.get())));

- BindFunctionToObject(

distiller_obj, "closePanel",

base::Bind(

&mojom::DistillerJavaScriptService::HandleDistillerClosePanelCall,