Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: components/dom_distiller/core/dom_distiller_request_view_base.cc

Issue 2768093004: Remove unused feedback class in dom distiller component (Closed)
Patch Set: address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/css/distilledpage.css ('k') | components/dom_distiller/core/experiments.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/dom_distiller_request_view_base.cc
diff --git a/components/dom_distiller/core/dom_distiller_request_view_base.cc b/components/dom_distiller/core/dom_distiller_request_view_base.cc
index 2d505d93f9a68691b4152985889e61a968e42346..bc717770c6a666fa63cb3598675b9b5a61918259 100644
--- a/components/dom_distiller/core/dom_distiller_request_view_base.cc
+++ b/components/dom_distiller/core/dom_distiller_request_view_base.cc
@@ -56,10 +56,6 @@ void DomDistillerRequestViewBase::OnArticleReady(
SendJavaScript(viewer::GetSetTitleJs(article_proto->title()));
SendJavaScript(viewer::GetSetTextDirectionJs(text_direction));
SendJavaScript(viewer::GetUnsafeArticleContentJs(article_proto));
- // If any content was loaded, show the feedback form.
- if (ShouldShowFeedbackForm()) {
- SendJavaScript(viewer::GetShowFeedbackFormJs());
- }
} else {
// It's possible that we didn't get some incremental updates from the
// distiller. Ensure all remaining pages are flushed to the viewer.
@@ -91,10 +87,6 @@ void DomDistillerRequestViewBase::OnArticleUpdated(
// client.
SendJavaScript(viewer::GetSetTitleJs(page.title()));
SendJavaScript(viewer::GetSetTextDirectionJs(page.text_direction()));
- // If any content was loaded, show the feedback form.
- if (ShouldShowFeedbackForm()) {
- SendJavaScript(viewer::GetShowFeedbackFormJs());
- }
}
}
}
« no previous file with comments | « components/dom_distiller/core/css/distilledpage.css ('k') | components/dom_distiller/core/experiments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698