bindings: Use fixed-size integer types in the generated code.

bindings: Use fixed-size integer types in the generated code.

Not only does this make the generated code more aligned with the style
guide, but it also helps the ongoing work to add more NativeValueTraits
specializations for IDL types in order to support the record<K,V> type.

BUG=432749, 685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2731593003
Cr-Commit-Position: refs/heads/master@{#454841}
Committed: https://chromium.googlesource.com/chromium/src/+/1f9c453ba2dfb9dbf175486f64ceb55da41717f8

[Raphael Kubo da Costa (rakuco), 2017-03-03 13:38:04]

PTAL. This is necessary for the NativeValueTraits work discussed in
https://codereview.chromium.org/2709983004/, otherwise we end up with generated
code that looks like this:

  Vector<std::pair<String, int>> arg;
  arg = NativeValueTraits<IDLRecord<IDL::ByteString,
IDL::Byte>>::nativeValue(isolate, value, exceptionState);

which fails because nativeValue() will return a Vector<std::pair<String,
int8_t>> instead.

Of course, it's also possible to just make the IDL types being added have 'int'
and 'unsigned' as their ImplTypes, but doing so looks like a step in the wrong
direction.

[jsbell, 2017-03-03 18:13:21]

jsbell@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2017-03-03 18:13:22]

Drive-by comment: in v8_types.py the 64-bit integer (long long) types are listed
in some places that enumerate the types but not others. Perhaps add comments
where this is intentional?

(They're rare in the platform so it doesn't surprise me that we don't have them
everywhere.)

[Raphael Kubo da Costa (rakuco), 2017-03-04 18:48:38]

I've uploaded patch v2 with an explanation of why the 64-bit types aren't always
listed.

[haraken, 2017-03-05 07:07:20]

LGTM

https://codereview.chromium.org/2731593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (left):

https://codereview.chromium.org/2731593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:109: 'unsigned int',

Just to confirm: It's okay to remove unsigned int, right?

[bashi, 2017-03-05 23:35:16]

lgtm

[Yuki, 2017-03-06 04:44:20]

LGTM.

[Raphael Kubo da Costa (rakuco), 2017-03-06 07:53:00]

https://codereview.chromium.org/2731593003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/v8_types.py (left):

https://codereview.chromium.org/2731593003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/v8_types.py:109: 'unsigned int',
On 2017/03/05 07:07:20, haraken wrote:
> 
> Just to confirm: It's okay to remove unsigned int, right?

I think so. It's not a WebIDL type and it doesn't seem to be referenced anywhere
else in the bindings code.

[Raphael Kubo da Costa (rakuco), 2017-03-06 07:53:08]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-03-06 07:53:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 09:30:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488786788069020,
"parent_rev": "5cd3e773b0851d6e56bc2bcb46802c637c50b837", "commit_rev":
"1f9c453ba2dfb9dbf175486f64ceb55da41717f8"}

[commit-bot: I haz the power, 2017-03-06 09:31:09]

Description was changed from

==========
bindings: Use fixed-size integer types in the generated code.

Not only does this make the generated code more aligned with the style
guide, but it also helps the ongoing work to add more NativeValueTraits
specializations for IDL types in order to support the record<K,V> type.

BUG=432749,685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Use fixed-size integer types in the generated code.

Not only does this make the generated code more aligned with the style
guide, but it also helps the ongoing work to add more NativeValueTraits
specializations for IDL types in order to support the record<K,V> type.

BUG=432749,685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2731593003
Cr-Commit-Position: refs/heads/master@{#454841}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f9c453ba2dfb9dbf175486f64ce...
==========

[commit-bot: I haz the power, 2017-03-06 09:31:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f9c453ba2dfb9dbf175486f64ce...