third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

index 11ffa5a54cb7c93a698c7d35ccb126cbd59fb064..c6de14d2b7356e6ac08bef51f9a60420eab683dd 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp

@@ -72,7 +72,7 @@ static void uLongLongAttributeAttributeSetter(v8::Local<v8::Value> v8Value, cons

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestTypedefs", "uLongLongAttribute");

// Prepare the value to be set.

- unsigned long long cppValue = toUInt64(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ uint64_t cppValue = toUInt64(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.hadException())

return;

@@ -110,7 +110,7 @@ static void voidMethodArrayOfLongsArgMethod(const v8::FunctionCallbackInfo<v8::V

TestTypedefs* impl = V8TestTypedefs::toImpl(info.Holder());

- Vector<int> arrayOfLongsArg;

+ Vector<int32_t> arrayOfLongsArg;

int numArgsPassed = info.Length();

while (numArgsPassed > 0) {

if (!info[numArgsPassed - 1]->IsUndefined())

@@ -121,7 +121,7 @@ static void voidMethodArrayOfLongsArgMethod(const v8::FunctionCallbackInfo<v8::V

impl->voidMethodArrayOfLongsArg();

return;

}

- arrayOfLongsArg = toImplArray<Vector<int>>(info[0], 1, info.GetIsolate(), exceptionState);

+ arrayOfLongsArg = toImplArray<Vector<int32_t>>(info[0], 1, info.GetIsolate(), exceptionState);

if (exceptionState.hadException())

return;