third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

index cec4bd90ab03df1f49624e2b86a10ea8ff1a82d5..9c6ea666f5bb50de9c900dd5d5421ae0fa16fbd9 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp

@@ -207,7 +207,7 @@ static void alwaysExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterface5", "alwaysExposedAttribute");

// Prepare the value to be set.

- int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ int32_t cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.hadException())

return;

@@ -229,7 +229,7 @@ static void workerExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterface5", "workerExposedAttribute");

// Prepare the value to be set.

- int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ int32_t cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.hadException())

return;

@@ -251,7 +251,7 @@ static void windowExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterface5", "windowExposedAttribute");

// Prepare the value to be set.

- int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ int32_t cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.hadException())

return;