third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

index 7b1800650fbcbb09f37df96390d7189664674fa8..e7a8276a786fbb86e8ef112a23ab7054bd6108c9 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h

@@ -92,8 +92,8 @@ class CORE_EXPORT TestDictionary : public IDLDictionaryBase {

void setInternalDictionarySequenceMember(const HeapVector<InternalDictionary>&);

bool hasLongMember() const;

- int longMember() const;

- void setLongMember(int);

+ int32_t longMember() const;

+ void setLongMember(int32_t);

bool hasObjectMember() const;

ScriptValue objectMember() const;

@@ -202,7 +202,7 @@ class CORE_EXPORT TestDictionary : public IDLDictionaryBase {

bool m_hasInternalDictionarySequenceMember = false;

HeapVector<InternalDictionary> m_internalDictionarySequenceMember;

bool m_hasLongMember = false;

- int m_longMember;

+ int32_t m_longMember;

ScriptValue m_objectMember;

ScriptValue m_objectOrNullMember;

DoubleOrString m_otherDoubleOrStringMember;