Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)
Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
index fd812d8ece70aa084fd471dcea18575f542004cb..bd4c57bee75ad36acdd49e14fa4446704beb60c0 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
@@ -40,7 +40,7 @@ DEFINE_TRACE_WRAPPERS(LongCallbackFunction) {
visitor->traceWrappers(m_callback.cast<v8::Value>());
}
-bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int num1, int num2, int& returnValue) {
+bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int32_t num1, int32_t num2, int32_t& returnValue) {
if (!m_scriptState->contextIsValid())
return false;
@@ -69,7 +69,7 @@ bool LongCallbackFunction::call(ScriptWrappable* scriptWrappable, int num1, int
exceptionCatcher.SetVerbose(true);
if (V8ScriptRunner::callFunction(m_callback.newLocal(m_scriptState->isolate()), m_scriptState->getExecutionContext(), thisValue, 2, argv, m_scriptState->isolate()).ToLocal(&v8ReturnValue)) {
- int cppValue = toInt32(m_scriptState->isolate(), v8ReturnValue, NormalConversion, exceptionState);
+ int32_t cppValue = toInt32(m_scriptState->isolate(), v8ReturnValue, NormalConversion, exceptionState);
if (exceptionState.hadException())
return false;
returnValue = cppValue;

Powered by Google App Engine
This is Rietveld 408576698