Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)
Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
index 6b4f11ea307c2f1c2fc63f9d52d04eebc4ff827e..49e0108422f890305f9f7481a94c22a1dfb673f5 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
@@ -19,18 +19,18 @@ namespace blink {
LongOrTestDictionary::LongOrTestDictionary() : m_type(SpecificTypeNone) {}
-int LongOrTestDictionary::getAsLong() const {
+int32_t LongOrTestDictionary::getAsLong() const {
DCHECK(isLong());
return m_long;
}
-void LongOrTestDictionary::setLong(int value) {
+void LongOrTestDictionary::setLong(int32_t value) {
DCHECK(isNull());
m_long = value;
m_type = SpecificTypeLong;
}
-LongOrTestDictionary LongOrTestDictionary::fromLong(int value) {
+LongOrTestDictionary LongOrTestDictionary::fromLong(int32_t value) {
LongOrTestDictionary container;
container.setLong(value);
return container;
@@ -87,7 +87,7 @@ void V8LongOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v
}
if (v8Value->IsNumber()) {
- int cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
+ int32_t cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);
@@ -95,7 +95,7 @@ void V8LongOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v
}
{
- int cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
+ int32_t cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);

Powered by Google App Engine
This is Rietveld 408576698