third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h

index a479be908031d749df4ee0bc17ddcf832774c750..40de8bbc03a046280ca3f7a9a4bb64fc1c944c0c 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h

@@ -28,9 +28,9 @@ class CORE_EXPORT LongOrTestDictionary final {

bool isNull() const { return m_type == SpecificTypeNone; }

bool isLong() const { return m_type == SpecificTypeLong; }

- int getAsLong() const;

- void setLong(int);

- static LongOrTestDictionary fromLong(int);

+ int32_t getAsLong() const;

+ void setLong(int32_t);

+ static LongOrTestDictionary fromLong(int32_t);

bool isTestDictionary() const { return m_type == SpecificTypeTestDictionary; }

const TestDictionary& getAsTestDictionary() const;

@@ -50,7 +50,7 @@ class CORE_EXPORT LongOrTestDictionary final {

};

SpecificTypes m_type;

- int m_long;

+ int32_t m_long;

TestDictionary m_testDictionary;

friend CORE_EXPORT v8::Local<v8::Value> ToV8(const LongOrTestDictionary&, v8::Local<v8::Object>, v8::Isolate*);