third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

index ab3fcf0178950928789c1c56716208b1d010a5fb..927ca16334efe2bd5d313f22d7eafdd544044704 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp

@@ -44,11 +44,11 @@ void TestDictionaryDerivedImplementedAs::setDerivedStringMemberWithDefault(Strin

bool TestDictionaryDerivedImplementedAs::hasRequiredLongMember() const {

return m_hasRequiredLongMember;

}

-int TestDictionaryDerivedImplementedAs::requiredLongMember() const {

+int32_t TestDictionaryDerivedImplementedAs::requiredLongMember() const {

DCHECK(m_hasRequiredLongMember);

return m_requiredLongMember;

}

-void TestDictionaryDerivedImplementedAs::setRequiredLongMember(int value) {

+void TestDictionaryDerivedImplementedAs::setRequiredLongMember(int32_t value) {

m_requiredLongMember = value;

m_hasRequiredLongMember = true;

}