third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp - Issue 2731593003: bindings: Use fixed-size integer types in the generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)

Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/scripts/v8_types.py ('K') | « third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

index c3503f05d9e9fc8b06cea28113ae2d3b1d5b69c8..5215c5402150e98d82129d573c707977f3f4bcb0 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

@@ -264,7 +264,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value

if (longMemberValue.IsEmpty() || longMemberValue->IsUndefined()) {

// Do nothing.

} else {

- int longMember = toInt32(isolate, longMemberValue, NormalConversion, exceptionState);

+ int32_t longMember = toInt32(isolate, longMemberValue, NormalConversion, exceptionState);

if (exceptionState.hadException())

return;

impl.setLongMember(longMember);