Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp

Issue 2731593003: bindings: Use fixed-size integer types in the generated code. (Closed)
Patch Set: Explain why 64-bit integers are sometimes not listed Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
index 7d3662ce56634c687f8f76f58fbccefde4281487..b910fb9ed36931dae6d62c52a176329e6cacffea 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp
@@ -40,18 +40,18 @@ TestInterfaceOrLong TestInterfaceOrLong::fromTestInterface(TestInterfaceImplemen
return container;
}
-int TestInterfaceOrLong::getAsLong() const {
+int32_t TestInterfaceOrLong::getAsLong() const {
DCHECK(isLong());
return m_long;
}
-void TestInterfaceOrLong::setLong(int value) {
+void TestInterfaceOrLong::setLong(int32_t value) {
DCHECK(isNull());
m_long = value;
m_type = SpecificTypeLong;
}
-TestInterfaceOrLong TestInterfaceOrLong::fromLong(int value) {
+TestInterfaceOrLong TestInterfaceOrLong::fromLong(int32_t value) {
TestInterfaceOrLong container;
container.setLong(value);
return container;
@@ -79,7 +79,7 @@ void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8
}
if (v8Value->IsNumber()) {
- int cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
+ int32_t cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);
@@ -87,7 +87,7 @@ void V8TestInterfaceOrLong::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8
}
{
- int cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
+ int32_t cppValue = toInt32(isolate, v8Value, NormalConversion, exceptionState);
if (exceptionState.hadException())
return;
impl.setLong(cppValue);

Powered by Google App Engine
This is Rietveld 408576698