Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2723993002: Rename platform/Widget to platform/FrameViewBase in core. (Closed)

Created:
3 years, 9 months ago by joelhockey
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, sashab
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, krit, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, jchaffraix+rendering, kenneth.christiansen, kouhei+svg_chromium.org, leviw+renderwatch, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename platform/Widget to platform/FrameViewBase in core. BUG=697351 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2723993002 Cr-Commit-Position: refs/heads/master@{#453912} Committed: https://chromium.googlesource.com/chromium/src/+/e3bc614272b3065544777ce45f740e526ab41c6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -275 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 5 chunks +21 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 14 chunks +23 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 21 chunks +47 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrameClient.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrameView.cpp View 7 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 9 chunks +35 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 13 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/PluginDocument.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/input/ScrollManager.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 10 chunks +30 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/EmbeddedObjectPaintInvalidator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 chunk +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/plugins/PluginView.h View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
joelhockey
3 years, 9 months ago (2017-03-01 10:30:14 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-01 10:31:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2723993002/1
3 years, 9 months ago (2017-03-01 12:02:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 12:08:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e3bc614272b3065544777ce45f74...

Powered by Google App Engine
This is Rietveld 408576698