Position close buttons in bubbles based on a layout delegate constant.

Position close buttons in bubbles based on a layout delegate constant.

This replaces hardcoded constants in bubble_frame_view.cc with one plumbed from
the layout delegate.  This allows other types of controls to also use this
constant.

BUG=686285
TEST=none

Review-Url: https://codereview.chromium.org/2666803005
Cr-Commit-Position: refs/heads/master@{#448723}
Committed: https://chromium.googlesource.com/chromium/src/+/f3ae9f99eb8b04497ec2778d256102a61848eaec

[Peter Kasting, 2017-02-01 04:59:58]

pkasting@chromium.org changed reviewers:
+ ellyjones@chromium.org, sky@chromium.org

[Peter Kasting, 2017-02-01 04:59:59]

ellyjones: *layout_delegate*
sky: rest

[Peter Kasting, 2017-02-01 05:00:06]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 05:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 05:11:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 05:11:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Peter Kasting, 2017-02-01 05:15:55]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 05:16:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 06:18:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 06:18:13]

Dry run: This issue passed the CQ dry run.

[Elly Fong-Jones, 2017-02-01 15:55:05]

c/b/ui/views/harmony/* lgtm

[sky, 2017-02-01 16:55:07]

https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h
File ui/views/views_delegate.h (right):

https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate...
ui/views/views_delegate.h:223: virtual int GetCloseButtonMargin() const;
'close button' is rather generic, and it seems the current value is only
applicable to bubbles/dialogs. How about GetDialogCloseButtonMargin?

[Peter Kasting, 2017-02-07 04:45:29]

https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h
File ui/views/views_delegate.h (right):

https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate...
ui/views/views_delegate.h:223: virtual int GetCloseButtonMargin() const;
On 2017/02/01 16:55:07, sky wrote:
> 'close button' is rather generic, and it seems the current value is only
> applicable to bubbles/dialogs. How about GetDialogCloseButtonMargin?

SGTM

[Peter Kasting, 2017-02-07 04:45:43]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 04:45:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 05:35:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 05:35:03]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-07 18:26:53]

LGTM

[Peter Kasting, 2017-02-07 20:30:52]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2017-02-07 20:30:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2666803005/#ps60001
(title: "Review comments")

[commit-bot: I haz the power, 2017-02-07 20:31:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 20:38:35]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486499452294680,
"parent_rev": "ce6be73c58c3275a42ed81ba5935d336390ab680", "commit_rev":
"f3ae9f99eb8b04497ec2778d256102a61848eaec"}

[commit-bot: I haz the power, 2017-02-07 20:39:12]

Description was changed from

==========
Position close buttons in bubbles based on a layout delegate constant.

This replaces hardcoded constants in bubble_frame_view.cc with one plumbed from
the layout delegate.  This allows other types of controls to also use this
constant.

BUG=686285
TEST=none
==========

to

==========
Position close buttons in bubbles based on a layout delegate constant.

This replaces hardcoded constants in bubble_frame_view.cc with one plumbed from
the layout delegate.  This allows other types of controls to also use this
constant.

BUG=686285
TEST=none

Review-Url: https://codereview.chromium.org/2666803005
Cr-Commit-Position: refs/heads/master@{#448723}
Committed:
https://chromium.googlesource.com/chromium/src/+/f3ae9f99eb8b04497ec2778d2561...
==========

[commit-bot: I haz the power, 2017-02-07 20:39:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f3ae9f99eb8b04497ec2778d2561...