Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)

Created:
3 years, 10 months ago by Peter Kasting
Modified:
3 years, 10 months ago
Reviewers:
Elly Fong-Jones, sky
CC:
chromium-reviews, tfarina, groby+bubble_chromium.org, rouslan+bubble_chromium.org, msw+watch_chromium.org, hcarmona+bubble_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Position close buttons in bubbles based on a layout delegate constant. This replaces hardcoded constants in bubble_frame_view.cc with one plumbed from the layout delegate. This allows other types of controls to also use this constant. BUG=686285 TEST=none Review-Url: https://codereview.chromium.org/2666803005 Cr-Commit-Position: refs/heads/master@{#448723} Committed: https://chromium.googlesource.com/chromium/src/+/f3ae9f99eb8b04497ec2778d256102a61848eaec

Patch Set 1 #

Patch Set 2 : Make dependent #

Patch Set 3 : Remove extraneous brace #

Total comments: 2

Patch Set 4 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -17 lines) Patch
M chrome/browser/ui/views/chrome_views_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/harmony_layout_delegate.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/harmony/layout_delegate.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_frame_view.cc View 1 2 3 3 chunks +6 lines, -17 lines 0 comments Download
M ui/views/layout/layout_constants.h View 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/views_delegate.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/views_delegate.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (17 generated)
Peter Kasting
ellyjones: *layout_delegate* sky: rest
3 years, 10 months ago (2017-02-01 04:59:59 UTC) #2
Elly Fong-Jones
c/b/ui/views/harmony/* lgtm
3 years, 10 months ago (2017-02-01 15:55:05 UTC) #11
sky
https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h File ui/views/views_delegate.h (right): https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h#newcode223 ui/views/views_delegate.h:223: virtual int GetCloseButtonMargin() const; 'close button' is rather generic, ...
3 years, 10 months ago (2017-02-01 16:55:07 UTC) #12
Peter Kasting
https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h File ui/views/views_delegate.h (right): https://codereview.chromium.org/2666803005/diff/40001/ui/views/views_delegate.h#newcode223 ui/views/views_delegate.h:223: virtual int GetCloseButtonMargin() const; On 2017/02/01 16:55:07, sky wrote: ...
3 years, 10 months ago (2017-02-07 04:45:29 UTC) #13
sky
LGTM
3 years, 10 months ago (2017-02-07 18:26:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2666803005/60001
3 years, 10 months ago (2017-02-07 20:31:28 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:39:13 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f3ae9f99eb8b04497ec2778d2561...

Powered by Google App Engine
This is Rietveld 408576698