Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | chrome/browser/ui/views/harmony/layout_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
diff --git a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
index c833ef37f23fbc48a9257d1f27cb5ec8336ebe60..fa3f7ce43dbc7a5eff6cb71c95a54eaf9cd7e960 100644
--- a/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
+++ b/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
@@ -19,6 +19,10 @@ int HarmonyLayoutDelegate::GetMetric(Metric metric) const {
switch (metric) {
case Metric::DIALOG_BUTTON_MARGIN:
return kHarmonyLayoutUnit;
+ case Metric::DIALOG_CLOSE_BUTTON_MARGIN:
+ // TODO(pkasting): The "- 4" here is a hack that matches the extra padding
+ // in vector_icon_button.cc and should be removed when that padding is.
+ return (kHarmonyLayoutUnit / 2) - 4;
case Metric::PANEL_CONTENT_MARGIN:
return kHarmonyLayoutUnit;
case Metric::RELATED_BUTTON_HORIZONTAL_SPACING:
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.cc ('k') | chrome/browser/ui/views/harmony/layout_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698