ui/views/layout/layout_constants.h - Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/layout/layout_constants.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)

Patch Set: Review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/layout/layout_constants.h

diff --git a/ui/views/layout/layout_constants.h b/ui/views/layout/layout_constants.h

index 798a4401cbcb8cb825a5253737c29acfab57693a..a0ab3f1abe59ded939903d8ddc6d98cc744a28fb 100644

--- a/ui/views/layout/layout_constants.h

+++ b/ui/views/layout/layout_constants.h

@@ -70,6 +70,9 @@ constexpr int kButtonVEdgeMarginNew = 20;

// left or right of a button (when using new style dialogs).

constexpr int kButtonHEdgeMarginNew = 20;

+// Spacing between the edge of the window and the edge of the close button.

+const int kCloseButtonMargin = 7;

// Horizontal spacing between buttons that are logically related.

constexpr int kRelatedButtonHSpacing = 6;

« no previous file with comments | « ui/views/bubble/bubble_frame_view.cc ('k') | ui/views/views_delegate.h » ('j') | no next file with comments »