chrome/browser/ui/views/harmony/layout_delegate.h - Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/harmony/layout_delegate.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)

Patch Set: Review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/harmony/layout_delegate.h

diff --git a/chrome/browser/ui/views/harmony/layout_delegate.h b/chrome/browser/ui/views/harmony/layout_delegate.h

index cd3c11e603b81808e155ded96d900bc06fbb5568..389280f4f5737839fa3e14a46f9d7933e81ed74c 100644

--- a/chrome/browser/ui/views/harmony/layout_delegate.h

+++ b/chrome/browser/ui/views/harmony/layout_delegate.h

@@ -13,6 +13,9 @@ class LayoutDelegate {

// Horizontal or vertical margin between the edge of a dialog and a

// contained button.

DIALOG_BUTTON_MARGIN,

+ // Horizontal or vertical margin between the edge of a dialog and the close

+ // button in the upper trailing corner.

+ DIALOG_CLOSE_BUTTON_MARGIN,

// Horizontal or vertical margin between the edge of a panel and the

// contained content.

PANEL_CONTENT_MARGIN,