Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/chrome_views_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_
6 #define CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_ 6 #define CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 ui::ContextFactory* GetContextFactory() override; 56 ui::ContextFactory* GetContextFactory() override;
57 ui::ContextFactoryPrivate* GetContextFactoryPrivate() override; 57 ui::ContextFactoryPrivate* GetContextFactoryPrivate() override;
58 std::string GetApplicationName() override; 58 std::string GetApplicationName() override;
59 #if defined(OS_WIN) 59 #if defined(OS_WIN)
60 int GetAppbarAutohideEdges(HMONITOR monitor, 60 int GetAppbarAutohideEdges(HMONITOR monitor,
61 const base::Closure& callback) override; 61 const base::Closure& callback) override;
62 #endif 62 #endif
63 scoped_refptr<base::TaskRunner> GetBlockingPoolTaskRunner() override; 63 scoped_refptr<base::TaskRunner> GetBlockingPoolTaskRunner() override;
64 64
65 gfx::Insets GetDialogButtonInsets() const override; 65 gfx::Insets GetDialogButtonInsets() const override;
66 int GetDialogCloseButtonMargin() const override;
66 int GetDialogRelatedButtonHorizontalSpacing() const override; 67 int GetDialogRelatedButtonHorizontalSpacing() const override;
67 int GetDialogRelatedControlVerticalSpacing() const override; 68 int GetDialogRelatedControlVerticalSpacing() const override;
68 gfx::Insets GetDialogFrameViewInsets() const override; 69 gfx::Insets GetDialogFrameViewInsets() const override;
69 gfx::Insets GetBubbleDialogMargins() const override; 70 gfx::Insets GetBubbleDialogMargins() const override;
70 71
71 private: 72 private:
72 #if defined(OS_WIN) 73 #if defined(OS_WIN)
73 typedef std::map<HMONITOR, int> AppbarAutohideEdgeMap; 74 typedef std::map<HMONITOR, int> AppbarAutohideEdgeMap;
74 75
75 // Callback on main thread with the edges. |returned_edges| is the value that 76 // Callback on main thread with the edges. |returned_edges| is the value that
(...skipping 22 matching lines...) Expand all
98 // GetAutohideEdges().start a new query. 99 // GetAutohideEdges().start a new query.
99 bool in_autohide_edges_callback_; 100 bool in_autohide_edges_callback_;
100 101
101 base::WeakPtrFactory<ChromeViewsDelegate> weak_factory_; 102 base::WeakPtrFactory<ChromeViewsDelegate> weak_factory_;
102 #endif 103 #endif
103 104
104 DISALLOW_COPY_AND_ASSIGN(ChromeViewsDelegate); 105 DISALLOW_COPY_AND_ASSIGN(ChromeViewsDelegate);
105 }; 106 };
106 107
107 #endif // CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_ 108 #endif // CHROME_BROWSER_UI_VIEWS_CHROME_VIEWS_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/views/chrome_views_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698