Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: ui/views/layout/layout_constants.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/bubble/bubble_frame_view.cc ('k') | ui/views/views_delegate.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_ 5 #ifndef UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_
6 #define UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_ 6 #define UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "ui/views/layout/grid_layout.h" 9 #include "ui/views/layout/grid_layout.h"
10 10
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 constexpr int kButtonHEdgeMargin = 13; 63 constexpr int kButtonHEdgeMargin = 13;
64 64
65 // Vertical spacing between the edge of the window and the 65 // Vertical spacing between the edge of the window and the
66 // top or bottom of a button (when using new style dialogs). 66 // top or bottom of a button (when using new style dialogs).
67 constexpr int kButtonVEdgeMarginNew = 20; 67 constexpr int kButtonVEdgeMarginNew = 20;
68 68
69 // Horizontal spacing between the edge of the window and the 69 // Horizontal spacing between the edge of the window and the
70 // left or right of a button (when using new style dialogs). 70 // left or right of a button (when using new style dialogs).
71 constexpr int kButtonHEdgeMarginNew = 20; 71 constexpr int kButtonHEdgeMarginNew = 20;
72 72
73 // Spacing between the edge of the window and the edge of the close button.
74 const int kCloseButtonMargin = 7;
75
73 // Horizontal spacing between buttons that are logically related. 76 // Horizontal spacing between buttons that are logically related.
74 constexpr int kRelatedButtonHSpacing = 6; 77 constexpr int kRelatedButtonHSpacing = 6;
75 78
76 // Indent of checkboxes relative to related text. 79 // Indent of checkboxes relative to related text.
77 constexpr int kCheckboxIndent = 10; 80 constexpr int kCheckboxIndent = 10;
78 81
79 // Horizontal spacing between the end of an item (i.e. an icon or a checkbox) 82 // Horizontal spacing between the end of an item (i.e. an icon or a checkbox)
80 // and the start of its corresponding text. 83 // and the start of its corresponding text.
81 constexpr int kItemLabelSpacing = 10; 84 constexpr int kItemLabelSpacing = 10;
82 85
83 } // namespace views 86 } // namespace views
84 87
85 #endif // UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_ 88 #endif // UI_VIEWS_LAYOUT_LAYOUT_CONSTANTS_H_
OLDNEW
« no previous file with comments | « ui/views/bubble/bubble_frame_view.cc ('k') | ui/views/views_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698