Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: ui/views/views_delegate.h

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Remove extraneous brace Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/layout/layout_constants.h ('k') | ui/views/views_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_VIEWS_VIEWS_DELEGATE_H_ 5 #ifndef UI_VIEWS_VIEWS_DELEGATE_H_
6 #define UI_VIEWS_VIEWS_DELEGATE_H_ 6 #define UI_VIEWS_VIEWS_DELEGATE_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #if defined(OS_WIN) 10 #if defined(OS_WIN)
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 211
212 // Returns the insets that should be applied around a dialog's frame view. 212 // Returns the insets that should be applied around a dialog's frame view.
213 virtual gfx::Insets GetDialogFrameViewInsets(); 213 virtual gfx::Insets GetDialogFrameViewInsets();
214 214
215 // Returns the margins that should be applied around a bubble dialog. 215 // Returns the margins that should be applied around a bubble dialog.
216 virtual gfx::Insets GetBubbleDialogMargins(); 216 virtual gfx::Insets GetBubbleDialogMargins();
217 217
218 // Returns the padding that should be placed around a button's content. 218 // Returns the padding that should be placed around a button's content.
219 virtual gfx::Insets GetButtonPadding() const; 219 virtual gfx::Insets GetButtonPadding() const;
220 220
221 // Returns the distance between a dialog's edge and the close button in the
222 // upper trailing corner.
223 virtual int GetCloseButtonMargin() const;
sky 2017/02/01 16:55:07 'close button' is rather generic, and it seems the
Peter Kasting 2017/02/07 04:45:29 SGTM
224
221 protected: 225 protected:
222 ViewsDelegate(); 226 ViewsDelegate();
223 227
224 private: 228 private:
225 std::unique_ptr<ViewsTouchEditingControllerFactory> views_tsc_factory_; 229 std::unique_ptr<ViewsTouchEditingControllerFactory> views_tsc_factory_;
226 230
227 #if defined(USE_AURA) 231 #if defined(USE_AURA)
228 std::unique_ptr<TouchSelectionMenuRunnerViews> touch_selection_menu_runner_; 232 std::unique_ptr<TouchSelectionMenuRunnerViews> touch_selection_menu_runner_;
229 #endif 233 #endif
230 234
231 NativeWidgetFactory native_widget_factory_; 235 NativeWidgetFactory native_widget_factory_;
232 236
233 DISALLOW_COPY_AND_ASSIGN(ViewsDelegate); 237 DISALLOW_COPY_AND_ASSIGN(ViewsDelegate);
234 }; 238 };
235 239
236 } // namespace views 240 } // namespace views
237 241
238 #endif // UI_VIEWS_VIEWS_DELEGATE_H_ 242 #endif // UI_VIEWS_VIEWS_DELEGATE_H_
OLDNEW
« no previous file with comments | « ui/views/layout/layout_constants.h ('k') | ui/views/views_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698