chrome/browser/ui/views/chrome_views_delegate.cc - Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)

Patch Set: Review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/chrome_views_delegate.cc

diff --git a/chrome/browser/ui/views/chrome_views_delegate.cc b/chrome/browser/ui/views/chrome_views_delegate.cc

index 8eb0a06b0f4505e36d25363a3ef9ca50028e4e60..3d0106ef6b5557a71468184442e0ab6091974824 100644

--- a/chrome/browser/ui/views/chrome_views_delegate.cc

+++ b/chrome/browser/ui/views/chrome_views_delegate.cc

@@ -546,6 +546,11 @@ gfx::Insets ChromeViewsDelegate::GetDialogButtonInsets() const {

LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN));

}

+int ChromeViewsDelegate::GetDialogCloseButtonMargin() const {

+ return LayoutDelegate::Get()->GetMetric(

+ LayoutDelegate::Metric::DIALOG_CLOSE_BUTTON_MARGIN);

int ChromeViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() const {

return LayoutDelegate::Get()->GetMetric(

LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING);