Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: ui/views/views_delegate.cc

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/views_delegate.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/views_delegate.h" 5 #include "ui/views/views_delegate.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "ui/views/layout/layout_constants.h" 9 #include "ui/views/layout/layout_constants.h"
10 #include "ui/views/views_touch_selection_controller_factory.h" 10 #include "ui/views/views_touch_selection_controller_factory.h"
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 124
125 scoped_refptr<base::TaskRunner> ViewsDelegate::GetBlockingPoolTaskRunner() { 125 scoped_refptr<base::TaskRunner> ViewsDelegate::GetBlockingPoolTaskRunner() {
126 return nullptr; 126 return nullptr;
127 } 127 }
128 128
129 gfx::Insets ViewsDelegate::GetDialogButtonInsets() const { 129 gfx::Insets ViewsDelegate::GetDialogButtonInsets() const {
130 return gfx::Insets(0, kButtonHEdgeMarginNew, kButtonVEdgeMarginNew, 130 return gfx::Insets(0, kButtonHEdgeMarginNew, kButtonVEdgeMarginNew,
131 kButtonHEdgeMarginNew); 131 kButtonHEdgeMarginNew);
132 } 132 }
133 133
134 int ViewsDelegate::GetDialogCloseButtonMargin() const {
135 return kCloseButtonMargin;
136 }
137
134 int ViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() const { 138 int ViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() const {
135 return kRelatedButtonHSpacing; 139 return kRelatedButtonHSpacing;
136 } 140 }
137 141
138 int ViewsDelegate::GetDialogRelatedControlVerticalSpacing() const { 142 int ViewsDelegate::GetDialogRelatedControlVerticalSpacing() const {
139 return kRelatedControlVerticalSpacing; 143 return kRelatedControlVerticalSpacing;
140 } 144 }
141 145
142 gfx::Insets ViewsDelegate::GetDialogFrameViewInsets() const { 146 gfx::Insets ViewsDelegate::GetDialogFrameViewInsets() const {
143 return gfx::Insets(kPanelVertMargin, kButtonHEdgeMarginNew, 0, 147 return gfx::Insets(kPanelVertMargin, kButtonHEdgeMarginNew, 0,
(...skipping 10 matching lines...) Expand all
154 views_delegate = this; 158 views_delegate = this;
155 159
156 ui::TouchEditingControllerFactory::SetInstance(views_tsc_factory_.get()); 160 ui::TouchEditingControllerFactory::SetInstance(views_tsc_factory_.get());
157 161
158 #if defined(USE_AURA) 162 #if defined(USE_AURA)
159 touch_selection_menu_runner_.reset(new TouchSelectionMenuRunnerViews()); 163 touch_selection_menu_runner_.reset(new TouchSelectionMenuRunnerViews());
160 #endif 164 #endif
161 } 165 }
162 166
163 } // namespace views 167 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/views_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698