Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: chrome/browser/ui/views/chrome_views_delegate.cc

Issue 2666803005: Position close buttons in bubbles based on a layout delegate constant. (Closed)
Patch Set: Review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/chrome_views_delegate.h" 5 #include "chrome/browser/ui/views/chrome_views_delegate.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 scoped_refptr<base::TaskRunner> 539 scoped_refptr<base::TaskRunner>
540 ChromeViewsDelegate::GetBlockingPoolTaskRunner() { 540 ChromeViewsDelegate::GetBlockingPoolTaskRunner() {
541 return content::BrowserThread::GetBlockingPool(); 541 return content::BrowserThread::GetBlockingPool();
542 } 542 }
543 543
544 gfx::Insets ChromeViewsDelegate::GetDialogButtonInsets() const { 544 gfx::Insets ChromeViewsDelegate::GetDialogButtonInsets() const {
545 return gfx::Insets(LayoutDelegate::Get()->GetMetric( 545 return gfx::Insets(LayoutDelegate::Get()->GetMetric(
546 LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN)); 546 LayoutDelegate::Metric::DIALOG_BUTTON_MARGIN));
547 } 547 }
548 548
549 int ChromeViewsDelegate::GetDialogCloseButtonMargin() const {
550 return LayoutDelegate::Get()->GetMetric(
551 LayoutDelegate::Metric::DIALOG_CLOSE_BUTTON_MARGIN);
552 }
553
549 int ChromeViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() const { 554 int ChromeViewsDelegate::GetDialogRelatedButtonHorizontalSpacing() const {
550 return LayoutDelegate::Get()->GetMetric( 555 return LayoutDelegate::Get()->GetMetric(
551 LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING); 556 LayoutDelegate::Metric::RELATED_BUTTON_HORIZONTAL_SPACING);
552 } 557 }
553 558
554 int ChromeViewsDelegate::GetDialogRelatedControlVerticalSpacing() const { 559 int ChromeViewsDelegate::GetDialogRelatedControlVerticalSpacing() const {
555 return LayoutDelegate::Get()->GetMetric( 560 return LayoutDelegate::Get()->GetMetric(
556 LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING); 561 LayoutDelegate::Metric::RELATED_CONTROL_VERTICAL_SPACING);
557 } 562 }
558 563
(...skipping 12 matching lines...) Expand all
571 LayoutDelegate::Metric::PANEL_CONTENT_MARGIN)); 576 LayoutDelegate::Metric::PANEL_CONTENT_MARGIN));
572 } 577 }
573 578
574 #if !defined(USE_ASH) 579 #if !defined(USE_ASH)
575 views::Widget::InitParams::WindowOpacity 580 views::Widget::InitParams::WindowOpacity
576 ChromeViewsDelegate::GetOpacityForInitParams( 581 ChromeViewsDelegate::GetOpacityForInitParams(
577 const views::Widget::InitParams& params) { 582 const views::Widget::InitParams& params) {
578 return views::Widget::InitParams::OPAQUE_WINDOW; 583 return views::Widget::InitParams::OPAQUE_WINDOW;
579 } 584 }
580 #endif 585 #endif
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/chrome_views_delegate.h ('k') | chrome/browser/ui/views/harmony/harmony_layout_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698