Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
msw
CC:
chromium-reviews, msramek+watch_chromium.org, skanuj+watch_chromium.org, sadrul, oshima+watch_chromium.org, alemate+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, achuith+watch_chromium.org, raymes+watch_chromium.org, melevin+watch_chromium.org, media-router+watch_chromium.org, jfweitz+watch_chromium.org, David Black, dcheng, samarth+watch_chromium.org, tfarina, kalyank, markusheintz_, kmadhusu+watch_chromium.org, Jered, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd Cr-Commit-Position: refs/heads/master@{#425881}

Patch Set 1 #

Patch Set 2 : explicit types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -115 lines) Patch
M chrome/browser/ui/ash/app_sync_ui_state.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_media_router.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/bookmarks/recently_used_folders_combo_model.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/ime/ime_window.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_ui.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_model.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/settings_window_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.cc View 1 9 chunks +24 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 5 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/chosen_object_row.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/website_settings/permission_selector_row.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_state_informer.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/touch_view_controller_delegate.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/login_ui_service.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Eric Willigers
In https://codereview.chromium.org/2422073002/ sky@ preferred explicit types instead of auto. Should chrome/browser/ui also use explicit types?
4 years, 2 months ago (2016-10-18 00:23:01 UTC) #4
msw
On 2016/10/18 00:23:01, Eric Willigers wrote: > In https://codereview.chromium.org/2422073002/ > sky@ preferred explicit types instead ...
4 years, 2 months ago (2016-10-18 00:49:31 UTC) #5
Eric Willigers
> > In https://codereview.chromium.org/2422073002/ > > sky@ preferred explicit types instead of auto. > > ...
4 years, 2 months ago (2016-10-18 01:11:28 UTC) #6
msw
nice, lgtm!
4 years, 2 months ago (2016-10-18 01:24:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424853003/20001
4 years, 2 months ago (2016-10-18 02:12:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 03:19:08 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 03:21:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c2422f2cbdaee59dd22ebb9821e06fb2fdda2dd
Cr-Commit-Position: refs/heads/master@{#425881}

Powered by Google App Engine
This is Rietveld 408576698