Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui

chrome/browser/ui/browser_list.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_list.h"
 
 #include <algorithm>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
@@ skipping 43 matching lines @@
   DCHECK(browser);
   GetInstance()->browsers_.push_back(browser);
 
   browser->RegisterKeepAlive();
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_BROWSER_OPENED,
       content::Source<Browser>(browser),
       content::NotificationService::NoDetails());
 
-  FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
-                    OnBrowserAdded(browser));
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserAdded(browser);
 }
 
 // static
 void BrowserList::RemoveBrowser(Browser* browser) {
   // Remove |browser| from the appropriate list instance.
   BrowserList* browser_list = GetInstance();
   RemoveBrowserFrom(browser, &browser_list->last_active_browsers_);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_BROWSER_CLOSED,
       content::Source<Browser>(browser),
       content::NotificationService::NoDetails());
 
   RemoveBrowserFrom(browser, &browser_list->browsers_);
 
-  FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
-                    OnBrowserRemoved(browser));
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserRemoved(browser);
 
   browser->UnregisterKeepAlive();
 
   // If we're exiting, send out the APP_TERMINATING notification to allow other
   // modules to shut themselves down.
   if (chrome::GetTotalBrowserCount() == 0 &&
       (browser_shutdown::IsTryingToQuit() ||
        g_browser_process->IsShuttingDown())) {
     // Last browser has just closed, and this is a user-initiated quit or there
     // is no module keeping the app alive, so send out our notification. No need
@@ skipping 116 matching lines @@
   // like [{b1, 0}, {b3, 0}, {b2, 1}, {b4, 1}].
   std::stable_partition(
       last_active_browsers.begin(), last_active_browsers.end(),
       [&new_workspace](Browser* browser) {
         return !browser->window()->IsVisibleOnAllWorkspaces() &&
                browser->window()->GetWorkspace() != new_workspace;
       });
 
   Browser* new_last_active = instance->GetLastActive();
   if (old_last_active != new_last_active) {
-    FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
-                      OnBrowserSetLastActive(new_last_active));
+    for (chrome::BrowserListObserver& observer : observers_.Get())
+      observer.OnBrowserSetLastActive(new_last_active);
   }
 }
 
 // static
 void BrowserList::SetLastActive(Browser* browser) {
   content::RecordAction(UserMetricsAction("ActiveBrowserChanged"));
 
   RemoveBrowserFrom(browser, &GetInstance()->last_active_browsers_);
   GetInstance()->last_active_browsers_.push_back(browser);
 
-  FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
-                    OnBrowserSetLastActive(browser));
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserSetLastActive(browser);
 }
 
 // static
 void BrowserList::NotifyBrowserNoLongerActive(Browser* browser) {
-  FOR_EACH_OBSERVER(chrome::BrowserListObserver, observers_.Get(),
-                    OnBrowserNoLongerActive(browser));
+  for (chrome::BrowserListObserver& observer : observers_.Get())
+    observer.OnBrowserNoLongerActive(browser);
 }
 
 // static
 bool BrowserList::IsIncognitoSessionActive() {
   for (auto* browser : *BrowserList::GetInstance()) {
     if (browser->profile()->IsOffTheRecord())
       return true;
   }
   return false;
 }
@@ skipping 19 matching lines @@
 }
 
 // static
 void BrowserList::RemoveBrowserFrom(Browser* browser,
                                     BrowserVector* browser_list) {
   BrowserVector::iterator remove_browser =
       std::find(browser_list->begin(), browser_list->end(), browser);
   if (remove_browser != browser_list->end())
     browser_list->erase(remove_browser);
 }