Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" 5 #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <limits> 10 #include <limits>
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 } 1184 }
1185 1185
1186 const char* BookmarkBarView::GetClassName() const { 1186 const char* BookmarkBarView::GetClassName() const {
1187 return kViewClassName; 1187 return kViewClassName;
1188 } 1188 }
1189 1189
1190 void BookmarkBarView::VisibilityChanged(View* starting_from, bool is_visible) { 1190 void BookmarkBarView::VisibilityChanged(View* starting_from, bool is_visible) {
1191 AccessiblePaneView::VisibilityChanged(starting_from, is_visible); 1191 AccessiblePaneView::VisibilityChanged(starting_from, is_visible);
1192 1192
1193 if (starting_from == this) { 1193 if (starting_from == this) {
1194 FOR_EACH_OBSERVER(BookmarkBarViewObserver, observers_, 1194 for (BookmarkBarViewObserver& observer : observers_)
1195 OnBookmarkBarVisibilityChanged()); 1195 observer.OnBookmarkBarVisibilityChanged();
1196 } 1196 }
1197 } 1197 }
1198 1198
1199 void BookmarkBarView::GetAccessibleState(ui::AXViewState* state) { 1199 void BookmarkBarView::GetAccessibleState(ui::AXViewState* state) {
1200 state->role = ui::AX_ROLE_TOOLBAR; 1200 state->role = ui::AX_ROLE_TOOLBAR;
1201 state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS); 1201 state->name = l10n_util::GetStringUTF16(IDS_ACCNAME_BOOKMARKS);
1202 } 1202 }
1203 1203
1204 void BookmarkBarView::AnimationProgressed(const gfx::Animation* animation) { 1204 void BookmarkBarView::AnimationProgressed(const gfx::Animation* animation) {
1205 // |browser_view_| can be null during tests. 1205 // |browser_view_| can be null during tests.
(...skipping 908 matching lines...) Expand 10 before | Expand all | Expand 10 after
2114 return; 2114 return;
2115 apps_page_shortcut_->SetVisible(visible); 2115 apps_page_shortcut_->SetVisible(visible);
2116 UpdateBookmarksSeparatorVisibility(); 2116 UpdateBookmarksSeparatorVisibility();
2117 LayoutAndPaint(); 2117 LayoutAndPaint();
2118 } 2118 }
2119 2119
2120 void BookmarkBarView::OnShowManagedBookmarksPrefChanged() { 2120 void BookmarkBarView::OnShowManagedBookmarksPrefChanged() {
2121 if (UpdateOtherAndManagedButtonsVisibility()) 2121 if (UpdateOtherAndManagedButtonsVisibility())
2122 LayoutAndPaint(); 2122 LayoutAndPaint();
2123 } 2123 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | chrome/browser/ui/views/frame/browser_view_layout.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698