Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/browser/ui/webui/signin/login_ui_service.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/media_router/query_result_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/login_ui_service.h" 5 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
6 6
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/profiles/profile.h" 8 #include "chrome/browser/profiles/profile.h"
9 #include "chrome/browser/signin/signin_promo.h" 9 #include "chrome/browser/signin/signin_promo.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 30 matching lines...) Expand all
41 ui_list_.remove(ui); 41 ui_list_.remove(ui);
42 ui_list_.push_front(ui); 42 ui_list_.push_front(ui);
43 } 43 }
44 44
45 void LoginUIService::LoginUIClosed(LoginUI* ui) { 45 void LoginUIService::LoginUIClosed(LoginUI* ui) {
46 ui_list_.remove(ui); 46 ui_list_.remove(ui);
47 } 47 }
48 48
49 void LoginUIService::SyncConfirmationUIClosed( 49 void LoginUIService::SyncConfirmationUIClosed(
50 SyncConfirmationUIClosedResult result) { 50 SyncConfirmationUIClosedResult result) {
51 FOR_EACH_OBSERVER( 51 for (Observer& observer : observer_list_)
52 Observer, 52 observer.OnSyncConfirmationUIClosed(result);
53 observer_list_,
54 OnSyncConfirmationUIClosed(result));
55 } 53 }
56 54
57 void LoginUIService::ShowLoginPopup() { 55 void LoginUIService::ShowLoginPopup() {
58 #if defined(OS_CHROMEOS) 56 #if defined(OS_CHROMEOS)
59 NOTREACHED(); 57 NOTREACHED();
60 #else 58 #else
61 chrome::ScopedTabbedBrowserDisplayer displayer(profile_); 59 chrome::ScopedTabbedBrowserDisplayer displayer(profile_);
62 chrome::ShowBrowserSignin( 60 chrome::ShowBrowserSignin(
63 displayer.browser(), 61 displayer.browser(),
64 signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS); 62 signin_metrics::AccessPoint::ACCESS_POINT_EXTENSIONS);
(...skipping 20 matching lines...) Expand all
85 } 83 }
86 } 84 }
87 85
88 const base::string16& LoginUIService::GetLastLoginResult() const { 86 const base::string16& LoginUIService::GetLastLoginResult() const {
89 return last_login_result_; 87 return last_login_result_;
90 } 88 }
91 89
92 const base::string16& LoginUIService::GetLastLoginErrorEmail() const { 90 const base::string16& LoginUIService::GetLastLoginErrorEmail() const {
93 return last_login_error_email_; 91 return last_login_error_email_;
94 } 92 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/media_router/query_result_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698