chrome/browser/ui/settings_window_manager.cc - Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/settings_window_manager.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)

Patch Set: explicit types Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/settings_window_manager.cc

diff --git a/chrome/browser/ui/settings_window_manager.cc b/chrome/browser/ui/settings_window_manager.cc

index 0567638d8c81ef0b1f30cdb3c10e44ebda089186..d84d7280f7c6895bba89e8754eea9c1abf581f85 100644

--- a/chrome/browser/ui/settings_window_manager.cc

+++ b/chrome/browser/ui/settings_window_manager.cc

@@ -69,8 +69,8 @@ void SettingsWindowManager::ShowChromePageForProfile(Profile* profile,

settings_session_map_[profile] = params.browser->session_id().id();

DCHECK(params.browser->is_trusted_source());

- FOR_EACH_OBSERVER(SettingsWindowManagerObserver,

- observers_, OnNewSettingsWindow(params.browser));

+ for (SettingsWindowManagerObserver& observer : observers_)

+ observer.OnNewSettingsWindow(params.browser);

}

Browser* SettingsWindowManager::FindBrowserForProfile(Profile* profile) {