Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_bar.cc

Issue 2424853003: Remove FOR_EACH_OBSERVER macro usage in chrome/browser/ui (Closed)
Patch Set: explicit types Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/settings_window_manager.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/toolbar_actions_bar.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
index 961e8aeb12dd8653cdc895ac5972070df88314e7..8d06aa097e7459bcc6b7f63e005a30128c83c71f 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
@@ -149,8 +149,8 @@ ToolbarActionsBar::~ToolbarActionsBar() {
// the order of deletion between the views and the ToolbarActionsBar.
DCHECK(toolbar_actions_.empty()) <<
"Must call DeleteActions() before destruction.";
- FOR_EACH_OBSERVER(ToolbarActionsBarObserver, observers_,
- OnToolbarActionsBarDestroyed());
+ for (ToolbarActionsBarObserver& observer : observers_)
+ observer.OnToolbarActionsBarDestroyed();
}
// static
@@ -453,8 +453,8 @@ void ToolbarActionsBar::OnDragEnded() {
DCHECK(is_drag_in_progress_);
is_drag_in_progress_ = false;
- FOR_EACH_OBSERVER(ToolbarActionsBarObserver,
- observers_, OnToolbarActionDragDone());
+ for (ToolbarActionsBarObserver& observer : observers_)
+ observer.OnToolbarActionDragDone();
}
void ToolbarActionsBar::OnDragDrop(int dragged_index,
@@ -481,8 +481,8 @@ void ToolbarActionsBar::OnDragDrop(int dragged_index,
void ToolbarActionsBar::OnAnimationEnded() {
// Notify the observers now, since showing a bubble or popup could potentially
// cause another animation to start.
- FOR_EACH_OBSERVER(ToolbarActionsBarObserver, observers_,
- OnToolbarActionsBarAnimationEnded());
+ for (ToolbarActionsBarObserver& observer : observers_)
+ observer.OnToolbarActionsBarAnimationEnded();
// Check if we were waiting for animation to complete to either show a
// message bubble, or to show a popup.
@@ -735,8 +735,8 @@ void ToolbarActionsBar::ResizeDelegate(gfx::Tween::Type tween_type,
delegate_->Redraw(false);
}
- FOR_EACH_OBSERVER(ToolbarActionsBarObserver,
- observers_, OnToolbarActionsBarDidStartResize());
+ for (ToolbarActionsBarObserver& observer : observers_)
+ observer.OnToolbarActionsBarDidStartResize();
}
void ToolbarActionsBar::OnToolbarHighlightModeChanged(bool is_highlighting) {
« no previous file with comments | « chrome/browser/ui/settings_window_manager.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698